Skip to content

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Sep 10, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 10, 2024
@gaius-qi gaius-qi self-assigned this Sep 10, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 10, 2024 14:13
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 12.16216% with 65 lines in your changes missing coverage. Please review.

Project coverage is 51.82%. Comparing base (8a1e858) to head (0f8e553).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/job/job.go 0.00% 40 Missing ⚠️
scheduler/resource/host_manager_mock.go 0.00% 12 Missing ⚠️
scheduler/resource/host_manager.go 9.09% 10 Missing ⚠️
manager/job/preheat.go 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3497      +/-   ##
==========================================
- Coverage   51.95%   51.82%   -0.13%     
==========================================
  Files         190      190              
  Lines       20302    20362      +60     
==========================================
+ Hits        10547    10552       +5     
- Misses       8952     9007      +55     
  Partials      803      803              
Flag Coverage Δ
unittests 51.82% <12.16%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/graph/dag/dag.go 80.98% <100.00%> (ø)
pkg/graph/dg/dg.go 80.13% <100.00%> (ø)
scheduler/networktopology/network_topology.go 100.00% <100.00%> (ø)
manager/job/preheat.go 51.65% <50.00%> (-0.05%) ⬇️
scheduler/resource/host_manager.go 74.28% <9.09%> (-12.39%) ⬇️
scheduler/resource/host_manager_mock.go 31.81% <0.00%> (-4.39%) ⬇️
internal/job/job.go 14.72% <0.00%> (-5.71%) ⬇️

... and 4 files with indirect coverage changes

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/scope branch 2 times, most recently from 524ba8f to 3c51cb3 Compare September 11, 2024 06:53
…e/scope

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/scope branch 3 times, most recently from c354ed8 to 7ccf900 Compare September 11, 2024 13:05
hyy0322
hyy0322 previously approved these changes Sep 11, 2024
@gaius-qi gaius-qi changed the title feat: add scope for preheating job [WIP]feat: add scope for preheating job Sep 12, 2024
@gaius-qi gaius-qi force-pushed the feature/scope branch 5 times, most recently from a3a7997 to 50bee9b Compare September 12, 2024 13:25
@gaius-qi gaius-qi changed the title [WIP]feat: add scope for preheating job feat: add scope for preheating job Sep 12, 2024
yxxhero
yxxhero previously approved these changes Sep 12, 2024
@yxxhero
Copy link
Member

yxxhero commented Sep 12, 2024

@gaius-qi ci

@gaius-qi gaius-qi force-pushed the feature/scope branch 3 times, most recently from 070d93e to 4bcedd5 Compare September 13, 2024 08:14
@gaius-qi gaius-qi requested a review from a team as a code owner September 13, 2024 08:14
@gaius-qi gaius-qi force-pushed the feature/scope branch 2 times, most recently from 1351608 to eed6609 Compare September 13, 2024 13:31
…e/scope

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/scope branch 3 times, most recently from 0e33de8 to d818e98 Compare September 14, 2024 02:36
…e/scope

Signed-off-by: Gaius <gaius.qi@gmail.com>
@yxxhero
Copy link
Member

yxxhero commented Sep 14, 2024

@gaius-qi could we add some e2e tests?

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 76cf35f into main Sep 14, 2024
29 checks passed
@gaius-qi gaius-qi deleted the feature/scope branch September 14, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants